Skip to content

refactor(schematics): no longer duplicate files for inline flags #12273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

  • No longer duplicates the templates and stylesheets in order to support the inlineStyle and inlineTemplate flag for the schematics.

* No longer duplicates the templates and stylesheets in order to support the `inlineStyle` and `inlineTemplate` flag for the schematics.
@devversion devversion requested a review from amcdnl as a code owner July 18, 2018 23:21
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 18, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 19, 2018
@ngbot
Copy link

ngbot bot commented Jul 19, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@josephperrott josephperrott merged commit 5b72ec7 into angular:master Jul 19, 2018
Copy link
Contributor

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! This should be merged upstream to Angular repo IMO.

@devversion
Copy link
Member Author

That's a good idea, but I think before we try to push that to the CLI foundation, we need to add some improvements.

e.g. the indentation of the inlined files seems to be a bit off.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants