fix(snack-bar): prevent content from overriding configured aria-live message #12294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
the
target: patch
devversion
requested review from
crisbeto,
jelbourn and
josephperrott
as code owners
googlebot
added
the
cla: yes
jelbourn
reviewed
Jul 20, 2018
| @@ -26,7 +26,10 @@ export class MatSnackBarConfig<D = any> { | |||
| /** The politeness level for the MatAriaLiveAnnouncer announcement. */ | |||
| politeness?: AriaLivePoliteness = 'assertive'; | |||
|
|
|||
| /** Message to be announced by the MatAriaLiveAnnouncer */ | |||
| /** | |||
| * Message to be announced by the MatAriaLiveAnnouncer. When opening a snackbar without a custom | |||
There was a problem hiding this comment.
Could you correct this comment while you're here to just say LiveAnnouncer?
…message * Currently the `announcementMessage` config option is always being overwritten when opening a simple snackbar.
devversion
force-pushed
the
fix/snack-bar-pass-custom-announcement
branch
from
8d3140e to
9ee73c8
Compare
devversion
changed the title
|
@jelbourn Done. Can you have another look? |
jelbourn
added
pr: lgtm
action: merge
mmalerba
pushed a commit
that referenced
this pull request
Jul 30, 2018
…message (#12294) * Currently the `announcementMessage` config option is always being overwritten when opening a simple snackbar.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
announcementMessageconfig option is always being overwritten when opening a simple snackbar.