refactor(live-announcer): add unique class to identify live element #12309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds a unique class to the live announcer element that is automatically created by the `LiveAnnouncer`. Similarly to the overlay container, the live announcer should be also distinguishable (e.g. for testing)
devversion
added
the
target: patch
googlebot
added
the
cla: yes
jelbourn
approved these changes
Jul 24, 2018
jelbourn
added
pr: lgtm
action: merge
mmalerba
pushed a commit
that referenced
this pull request
Jul 30, 2018
…12309) * Adds a unique class to the live announcer element that is automatically created by the `LiveAnnouncer`. Similarly to the overlay container, the live announcer should be also distinguishable (e.g. for testing)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LiveAnnouncer. Similarly to the overlay container, the live announcer should be also distinguishable (e.g. for testing)This might look a bit unnecessary, but I think just creating a global DOM element that has
cdk-visually-hiddenis pretty much confusing. For testing, it's not really safe to either use[aria-live]or.cdk-visually-hiddenbecause there can be similar elements in the app. Also there might be use-cases where people want to customize the pre-created live element and could now easily query for the element.@jelbourn I don't really feel too strong about this, so I'm also fine closing this, if desired.