Skip to content

cleanup: use regex to whitelist branches for CI #12439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2018
Merged

cleanup: use regex to whitelist branches for CI #12439

merged 2 commits into from
Jul 31, 2018

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba added pr: merge safe target: patch This PR is targeted for the next patch release labels Jul 30, 2018
@mmalerba mmalerba requested a review from jelbourn July 30, 2018 18:03
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 30, 2018
jelbourn
jelbourn approved these changes Jul 30, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 30, 2018
devversion
devversion reviewed Jul 30, 2018
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also make sure we run CircleCI for such branches?

@mmalerba mmalerba force-pushed the master branch 3 times, most recently from 3b6dd46 to 257528f Compare July 30, 2018 20:05
@jelbourn jelbourn merged commit 37ba893 into angular:master Jul 31, 2018
jelbourn pushed a commit that referenced this pull request Aug 7, 2018
@mmalerba @jelbourn
chore: use regex to whitelist branches for CI (#12439)
ee63518
jelbourn pushed a commit that referenced this pull request Aug 7, 2018
@mmalerba @jelbourn
chore: use regex to whitelist branches for CI (#12439)
043cee5
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmalerba @jelbourn @devversion @googlebot