Skip to content

fix(datepicker): add 'multi-year' to union type for startView property #12518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2018

Conversation

Nevaan
Copy link
Contributor

@Nevaan Nevaan commented Aug 3, 2018

Adds missing literal to union type. The issue pointed out that the possible value 'multi-year' is not listed on API page.

Fixes #11700

Adds missing literal to union type. The issue pointed out that the possible value 'multi-year' is not listed on API page.

Fixes angular#11700
@Nevaan Nevaan requested a review from mmalerba as a code owner August 3, 2018 18:24
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Aug 3, 2018
@Nevaan
Copy link
Contributor Author

Nevaan commented Aug 3, 2018

CLA done

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Aug 3, 2018
@Nevaan
Copy link
Contributor Author

Nevaan commented Aug 3, 2018

Seems that travis builds fails, but not because of the code change ( response 502 Bad Gateway in one of e2e tests). Is this possible to trigger build manually?

also, mentioning @mmalerba as he asked on issue page

@Nevaan
Copy link
Contributor Author

Nevaan commented Aug 3, 2018

Travis-required fails also, but on the test of component I did not changed - how should I deal with it?

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels Aug 12, 2018
@crisbeto
Copy link
Member

Commit message fixup: should be marked as a fix instead of docs.

@Nevaan Nevaan changed the title docs(datepicker): add 'multi-year' to union type for startView property fix(datepicker): add 'multi-year' to union type for startView property Aug 12, 2018
@Nevaan
Copy link
Contributor Author

Nevaan commented Aug 12, 2018

Message changed, thank you!

@crisbeto crisbeto removed the merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed label Aug 12, 2018
@julianobrasil
Copy link
Contributor

Isn't this already included in #11049?

@jelbourn jelbourn merged commit 6f35fdc into angular:master Aug 22, 2018
jelbourn pushed a commit that referenced this pull request Aug 29, 2018
…ty (#12518)

Adds missing literal to union type. The issue pointed out that the possible value 'multi-year' is not listed on API page.

Fixes #11700
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: not all options for Datepicker are listed
5 participants