-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(datepicker): add 'multi-year' to union type for startView property #12518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds missing literal to union type. The issue pointed out that the possible value 'multi-year' is not listed on API page. Fixes angular#11700
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
CLA done |
CLAs look good, thanks! |
Seems that travis builds fails, but not because of the code change ( response 502 Bad Gateway in one of e2e tests). Is this possible to trigger build manually? also, mentioning @mmalerba as he asked on issue page |
Travis-required fails also, but on the test of component I did not changed - how should I deal with it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Commit message fixup: should be marked as a |
Message changed, thank you! |
Isn't this already included in #11049? |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds missing literal to union type. The issue pointed out that the possible value 'multi-year' is not listed on API page.
Fixes #11700