Skip to content

build: remove madge #12548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2018
Merged

Conversation

devversion
Copy link
Member

@devversion devversion commented Aug 6, 2018

Removes madge that doesn't seem to run properly. Madge claims to support .ts files, but from testing this does not work properly (also doesn't respect entry-points/packages).

Right now, we always transpile the files and then run Madge to check for circular dependencies.

But, Due to the fact that we run rollup to bundle entry-points, we have another circular dependency check that also respects entry-points/packages.

Sample rollup output:

{ code: 'CIRCULAR_DEPENDENCY',
  importer: 'dist\\packages\\material\\core\\A\\B.js',
  message: 'Circular dependency: A.js -> B.js -> A.js',
}

@devversion devversion requested a review from jelbourn as a code owner August 6, 2018 09:26
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 6, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 6, 2018
* Removes `madge` that doesn't run properly for TypeScript projects with path mappings (never detected anything; just slows down the lint task)

* Properly throws if a circular dependency has been detected by rollup.
@devversion devversion removed the action: merge The PR is ready for merge by the caretaker label Aug 6, 2018
@devversion
Copy link
Member Author

This is blocked on #12554 because I've just added that rollup circular dependency warnings throw an error.

@devversion devversion added blocked This issue is blocked by some external factor, such as a prerequisite PR and removed blocked labels Aug 6, 2018
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker and removed blocked This issue is blocked by some external factor, such as a prerequisite PR labels Aug 8, 2018
@josephperrott josephperrott merged commit fca1429 into angular:master Aug 8, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants