Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
madge
that doesn't seem to run properly. Madge claims to support.ts
files, but from testing this does not work properly (also doesn't respect entry-points/packages).Right now, we always transpile the files and then run Madge to check for circular dependencies.
But, Due to the fact that we run
rollup
to bundle entry-points, we have another circular dependency check that also respects entry-points/packages.Sample rollup output: