cleanup(cdk-scrollable): use fromEvent under the hood #12589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
reviewed
Aug 8, 2018
| private _scrollListener = (event: Event) => this._elementScrolled.next(event); | ||
| private _destroyed = new Subject(); | ||
|
|
||
| private _elementScrolled: Observable<Event> = Observable.create(observer => |
There was a problem hiding this comment.
Why do you need the Observable.create here? You can just do this:
private _elementScrolled = this._ngZone.runOutsideAngular(() => {
return fromEvent(...).pipe(takeUntil(this._destroyed), tap(() => ...));
});There was a problem hiding this comment.
What does the tap(() => ...) do here?
I was under the impression that the call to subscribe has to occur inside the runOutsideAngular function, that's why I did it this way
There was a problem hiding this comment.
Sorry, I forgot that about having to subscribe.
crisbeto
approved these changes
Aug 9, 2018
| private _scrollListener = (event: Event) => this._elementScrolled.next(event); | ||
| private _destroyed = new Subject(); | ||
|
|
||
| private _elementScrolled: Observable<Event> = Observable.create(observer => |
There was a problem hiding this comment.
Sorry, I forgot that about having to subscribe.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
technically a major change since I'm switching the
Observablefrom<any>to<Event>