Skip to content

fix(snackbar): wrap simple snackbar text in span #12599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2018
Merged

fix(snackbar): wrap simple snackbar text in span #12599

merged 1 commit into from
Aug 9, 2018

Conversation

josephperrott
Copy link
Member

No description provided.

@josephperrott josephperrott added the target: patch This PR is targeted for the next patch release label Aug 9, 2018
@josephperrott josephperrott requested a review from crisbeto August 9, 2018 15:05
@josephperrott josephperrott requested a review from jelbourn as a code owner August 9, 2018 15:05
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 9, 2018
crisbeto
crisbeto approved these changes Aug 9, 2018
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but out of curiosity, what's the reason for wrapping it?

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 9, 2018
@ngbot
Copy link

ngbot bot commented Aug 9, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: build" is failing
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@josephperrott
Copy link
Member Author

We have begun transforming our html templates in our internal syncs to include our license header which results in a new line above template. Specifically in the simple snack bar this adds a single space when looking at the elements textContent. By wrapping the content in a span it will ensure that the whitespace is consistent regardless of the presence of the license header comment.

@jelbourn
Copy link
Member

jelbourn commented Aug 9, 2018

@josephperrott can you add that explanation to the commit message?

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 9, 2018
@josephperrott
Copy link
Member Author

Done.

jelbourn
jelbourn approved these changes Aug 9, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott
fix(snackbar): wrap simple snackbar text in span
0d055de 
We have begun transforming our html templates in our internal syncs to include our license header
which results in a new line above template. In the simple snack bar this adds a single space when
looking at the elements textContent. By wrapping the content in a span we ensure that the
whitespace is consistent regardless of the presence of the license header comment in the template
file.
@josephperrott josephperrott merged commit ef0b84b into angular:master Aug 9, 2018
@josephperrott josephperrott deleted the snackbar-spacing-fix branch August 9, 2018 17:11
josephperrott added a commit that referenced this pull request Aug 9, 2018
@josephperrott
fix(snackbar): wrap simple snackbar text in span (#12599)
11b97e4 
We have begun transforming our html templates in our internal syncs to include our license header
which results in a new line above template. In the simple snack bar this adds a single space when
looking at the elements textContent. By wrapping the content in a span we ensure that the
whitespace is consistent regardless of the presence of the license header comment in the template
file.
josephperrott added a commit that referenced this pull request Aug 9, 2018
@josephperrott
fix(snackbar): wrap simple snackbar text in span (#12599)
aceba71 
We have begun transforming our html templates in our internal syncs to include our license header
which results in a new line above template. In the simple snack bar this adds a single space when
looking at the elements textContent. By wrapping the content in a span we ensure that the
whitespace is consistent regardless of the presence of the license header comment in the template
file.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josephperrott @jelbourn @crisbeto @googlebot