Skip to content

build: do not e2e tests on saucelabs #12700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

devversion
Copy link
Member

  • No longer runs e2e tests inside of Saucelabs because Chrome is also installed on Travis CI and we should keep Saucelabs available for other browsers that don't run inside of Dockers or Travis.

@devversion devversion added the in progress This issue is currently in progress label Aug 16, 2018
@devversion devversion requested a review from jelbourn as a code owner August 16, 2018 14:02
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 16, 2018
@devversion devversion force-pushed the build/e2e-tests-no-saucelabs branch 2 times, most recently from b9ebb79 to a40bd1a Compare August 16, 2018 14:39
* No longer runs e2e tests inside of Saucelabs because Chrome is also installed on Travis CI and we should keep Saucelabs available for other browsers that don't run inside of Dockers or Travis.
@devversion devversion added pr: merge safe and removed in progress This issue is currently in progress labels Aug 16, 2018
@devversion devversion force-pushed the build/e2e-tests-no-saucelabs branch from a40bd1a to 5b21983 Compare August 16, 2018 14:51
@devversion
Copy link
Member Author

Note: The test failures are coming from the slide-toggle spec-alignment PR.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 16, 2018
@mmalerba mmalerba merged commit 9d882a0 into angular:master Aug 16, 2018
mmalerba pushed a commit that referenced this pull request Aug 20, 2018
* No longer runs e2e tests inside of Saucelabs because Chrome is also installed on Travis CI and we should keep Saucelabs available for other browsers that don't run inside of Dockers or Travis.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants