fix(drag-drop): incorrectly displaying items if user skips multiple positions while sorting #12739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ositions while sorting The current logic for moving items around while sorting works by swapping the sorted item with the one above/below it. This works for most cases since the user is usually moving down one-by-one, however it breaks down if they move down quickly, causing the element to skip multiple positions. In this case the element would swap its position with the end item, rather than shifting an entire slice of the list. These changes rework the logic so it can handle these location skips correctly. It's also a prerequisite to being able to limit how far from the element sorting should work.
crisbeto
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic for moving items around while sorting works by swapping the sorted item with the one above/below it. This works for most cases since the user is usually moving down one-by-one, however it breaks down if they move down quickly, causing the element to skip multiple positions. In this case the element would swap its position with the end item, rather than shifting an entire slice of the list. These changes rework the logic so it can handle these location skips correctly. It's also a prerequisite to being able to limit how far from the element sorting should work.