Skip to content

fix(sidenav): not positioning correctly in rtl #12741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2018

Conversation

crisbeto
Copy link
Member

Adds a workaround for a Chrome issue where the sidenav content is partially cut off when dir='rtl' is set on the body or html nodes.

Note: this shouldn't be much of a breaking change for components that derive from the sidenav, because we're still keeping the original overflow-y: auto. Here's the issue for reference:
angular_material_-_google_chrome_2018-08-19_20-57-18

Adds a workaround for a Chrome issue where the sidenav content is partially cut off when `dir='rtl'` is set on the `body` or `html` nodes.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Aug 19, 2018
@crisbeto crisbeto requested a review from mmalerba as a code owner August 19, 2018 19:39
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 19, 2018
@@ -0,0 +1,3 @@
<div class="mat-drawer-inner-container">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little bit worried that this wrapper might interfere with styles people have added. We might need to bump this to major, lets see how the presubmit goes though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly what happened to us, maybe mention that the template changed in the changelog ?

@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 20, 2018
@jelbourn jelbourn merged commit 9d3d95f into angular:master Sep 14, 2018
.mat-drawer-inner-container {
width: 100%;
height: 100%;
overflow: auto;
Copy link

@Bored-Bohr Bored-Bohr Dec 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overflow causes the overflow to be applied to the inner container instead of the parent mat-sidenav. It will now look like
image
if you attempt to set styles such as padding or width to the mat-sidenav element

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants