Skip to content

fix(form-field): Make labels show while printing #12766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from Sep 18, 2018
Merged

fix(form-field): Make labels show while printing #12766

merged 7 commits into from Sep 18, 2018

Conversation

ghost
Copy link

@ghost ghost commented Aug 21, 2018

@mmalerba Look at this please

@ghost ghost requested a review from mmalerba as a code owner August 21, 2018 03:45
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Aug 21, 2018
@ghost
Copy link
Author

ghost commented Aug 21, 2018

I signed it

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Aug 21, 2018
// http://www.useragentman.com/blog/2014/05/04/fixing-typography-inside-of-2-d-css-transforms/
// This results in a small jitter after the label floats on Firefox, which the
// translateZ fixes.
transform: translateY(-$infix-margin-top - $infix-padding) scale($font-scale) perspective(100px);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you remove the perspective(100px) from this rule, I think we can get rid of the whole -ms-transform rule below. You'll probably need to move the + $mat-form-field-legacy-dedupe into the translateY though.

@ghost ghost requested a review from jelbourn as a code owner August 22, 2018 06:40
@mixin _mat-form-field-legacy-label-floating-print($font-scale, $infix-padding, $infix-margin-top) {
// This results in a small jitter after the label floats on Firefox, which the
// translateZ fixes.
transform: translateY(-$infix-margin-top - $infix-padding + $mat-form-field-legacy-dedupe) scale($font-scale);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there's a lint error because this line is too long, can you put the scale($font-scale) part on the next line?

@mmalerba
Copy link
Contributor

mmalerba commented Sep 7, 2018

fixes #12861

@mmalerba mmalerba added target: patch This PR is targeted for the next patch release pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 12, 2018
@mmalerba mmalerba merged commit e88271a into angular:master Sep 18, 2018
@Polyterative
Copy link

Is there any way to port this to 6.x? I can't upgrade my major because upgrading flex breaks everything

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants