-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(form-field): Make labels show while printing #12766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it |
CLAs look good, thanks! |
// http://www.useragentman.com/blog/2014/05/04/fixing-typography-inside-of-2-d-css-transforms/ | ||
// This results in a small jitter after the label floats on Firefox, which the | ||
// translateZ fixes. | ||
transform: translateY(-$infix-margin-top - $infix-padding) scale($font-scale) perspective(100px); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you remove the perspective(100px)
from this rule, I think we can get rid of the whole -ms-transform
rule below. You'll probably need to move the + $mat-form-field-legacy-dedupe
into the translateY
though.
@mixin _mat-form-field-legacy-label-floating-print($font-scale, $infix-padding, $infix-margin-top) { | ||
// This results in a small jitter after the label floats on Firefox, which the | ||
// translateZ fixes. | ||
transform: translateY(-$infix-margin-top - $infix-padding + $mat-form-field-legacy-dedupe) scale($font-scale); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there's a lint error because this line is too long, can you put the scale($font-scale)
part on the next line?
fixes #12861 |
Is there any way to port this to 6.x? I can't upgrade my major because upgrading flex breaks everything |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
@mmalerba Look at this please