Skip to content

refactor(text-field): allow ElementRef to be passed to autofill monitor #12783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/cdk/text-field/autofill.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -198,13 +198,13 @@ describe('cdkAutofill', () => {
}));

it('should monitor host element on init', () => {
expect(autofillMonitor.monitor).toHaveBeenCalledWith(testComponent.input.nativeElement);
expect(autofillMonitor.monitor).toHaveBeenCalledWith(testComponent.input);
});

it('should stop monitoring host element on destroy', () => {
expect(autofillMonitor.stopMonitoring).not.toHaveBeenCalled();
fixture.destroy();
expect(autofillMonitor.stopMonitoring).toHaveBeenCalledWith(testComponent.input.nativeElement);
expect(autofillMonitor.stopMonitoring).toHaveBeenCalledWith(testComponent.input);
});
});

Expand Down
27 changes: 23 additions & 4 deletions src/cdk/text-field/autofill.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,21 @@ export class AutofillMonitor implements OnDestroy {
* @param element The element to monitor.
* @return A stream of autofill state changes.
*/
monitor(element: Element): Observable<AutofillEvent> {
monitor(element: Element): Observable<AutofillEvent>;

/**
* Monitor for changes in the autofill state of the given input element.
* @param element The element to monitor.
* @return A stream of autofill state changes.
*/
monitor(element: ElementRef<Element>): Observable<AutofillEvent>;

monitor(elementOrRef: Element | ElementRef<Element>): Observable<AutofillEvent> {
if (!this._platform.isBrowser) {
return EMPTY;
}

const element = elementOrRef instanceof ElementRef ? elementOrRef.nativeElement : elementOrRef;
const info = this._monitoredElements.get(element);

if (info) {
Expand Down Expand Up @@ -103,7 +113,16 @@ export class AutofillMonitor implements OnDestroy {
* Stop monitoring the autofill state of the given input element.
* @param element The element to stop monitoring.
*/
stopMonitoring(element: Element) {
stopMonitoring(element: Element);

/**
* Stop monitoring the autofill state of the given input element.
* @param element The element to stop monitoring.
*/
stopMonitoring(element: ElementRef<Element>);

stopMonitoring(elementOrRef: Element | ElementRef<Element>) {
const element = elementOrRef instanceof ElementRef ? elementOrRef.nativeElement : elementOrRef;
const info = this._monitoredElements.get(element);

if (info) {
Expand Down Expand Up @@ -133,11 +152,11 @@ export class CdkAutofill implements OnDestroy, OnInit {

ngOnInit() {
this._autofillMonitor
.monitor(this._elementRef.nativeElement)
.monitor(this._elementRef)
.subscribe(event => this.cdkAutofill.emit(event));
}

ngOnDestroy() {
this._autofillMonitor.stopMonitoring(this._elementRef.nativeElement);
this._autofillMonitor.stopMonitoring(this._elementRef);
}
}
4 changes: 2 additions & 2 deletions src/lib/input/input.ts
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ export class MatInput extends _MatInputMixinBase implements MatFormFieldControl<
}

ngOnInit() {
this._autofillMonitor.monitor(this._elementRef.nativeElement).subscribe(event => {
this._autofillMonitor.monitor(this._elementRef).subscribe(event => {
this.autofilled = event.isAutofilled;
this.stateChanges.next();
});
Expand All @@ -266,7 +266,7 @@ export class MatInput extends _MatInputMixinBase implements MatFormFieldControl<

ngOnDestroy() {
this.stateChanges.complete();
this._autofillMonitor.stopMonitoring(this._elementRef.nativeElement);
this._autofillMonitor.stopMonitoring(this._elementRef);
}

ngDoCheck() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@ export class TextFieldAutofillMonitorExample implements OnDestroy, OnInit {
constructor(private autofill: AutofillMonitor) {}

ngOnInit() {
this.autofill.monitor(this.firstName.nativeElement)
this.autofill.monitor(this.firstName)
.subscribe(e => this.firstNameAutofilled = e.isAutofilled);
this.autofill.monitor(this.lastName.nativeElement)
this.autofill.monitor(this.lastName)
.subscribe(e => this.lastNameAutofilled = e.isAutofilled);
}

ngOnDestroy() {
this.autofill.stopMonitoring(this.firstName.nativeElement);
this.autofill.stopMonitoring(this.lastName.nativeElement);
this.autofill.stopMonitoring(this.firstName);
this.autofill.stopMonitoring(this.lastName);
}
}