fix(ng-add): inserted dependencies should be sorted #12847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In case someone runs `ng add @angular/material`, all required dependencies are just inserted at the end of the `dependencies` object. We should sort the dependencies after adding dependencies.
devversion
added
pr: merge safe
target: major
googlebot
added
the
cla: yes
jelbourn
reviewed
Aug 27, 2018
| @@ -8,19 +8,24 @@ | |||
|
|
|||
| import {Tree} from '@angular-devkit/schematics'; | |||
|
|
|||
| /** Function that sorts the keys of the specified object and returns the result as a new object. */ | |||
| const sortObjectByKeys = (obj: any) => Object.keys(obj).sort() | |||
| .reduce((result, key) => (result[key] = obj[key]) && result, {}); | |||
There was a problem hiding this comment.
- Define this using the
functionkeyword - I think you can use the
objecttype here - Function description should start with the verb:
/**
* Sorts the keys of the given object.
* @returns A new object instance with sorted keys
*/There was a problem hiding this comment.
Done. I did it like that because I wanted to somehow make clear that this isn't really part of the package-json functions. But seems like not having the export modifier is already clear enough.
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ng add @angular/material, all required dependencies are just inserted at the end of thedependenciesobject. We should sort the dependencies after adding dependencies.