refactor(schematics): cleanup method check, class inheritance and template misc rules #12850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
pr: merge safe
target: major
googlebot
added
the
cla: yes
devversion
force-pushed
the
refactor/cleanup-remaining-rules
branch
from
6ab17b3 to
73135d8
Compare
jelbourn
added
pr: lgtm
action: merge
|
@devversion can you change the first line of the commit message to reflect what's changed in this PR without the context of the ones that came before it? |
…plate misc rules * Fixes that the `method-check` rule does not throw if the type of a class instantiation could not be determined. * Cleans up the remaining rules. * Removes the `exportAs` rule for now. Since it's unused and also extremely brittle (search & replace). * Fixes that the template misc rule reports wrong line numbers for external templates.
devversion
force-pushed
the
refactor/cleanup-remaining-rules
branch
from
73135d8 to
4d73cb8
Compare
devversion
changed the title
|
@jelbourn I'm not entirely sure if I got it right. Please have another look. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
method-checkrule does not throw if the type of a class instantiation could not be determined.exportAsrule for now. Since it's unused and also extremely brittle (search & replace).