build: rework breaking changes tooling #12950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
crisbeto
commented
Sep 2, 2018
crisbeto
commented
- Reworks the breaking change tslint rule to remove the logic that checks that there are no expired breaking changes.
- Adds a new script that can be used to get an overview of the pending and expired breaking changes.
crisbeto
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
devversion
approved these changes
Sep 3, 2018
tools/gulp/tasks/breaking-changes.ts
Outdated
| */ | ||
| task('breaking-changes', () => { | ||
| const cwd = process.cwd(); | ||
| const configFile = ts.readJsonConfigFile(join(cwd, 'tsconfig.json'), ts.sys.readFile); |
There was a problem hiding this comment.
Would it be better to just refer to the build config's project directory?
I know that gulp always changes the CWD to the gulpfile directory
There was a problem hiding this comment.
Yeah I'd say so, I didn't know that we had it configured somewhere.
devversion
added
pr: lgtm
action: merge
* Reworks the breaking change tslint rule to remove the logic that checks that there are no expired breaking changes. * Adds a new script that can be used to get an overview of the pending and expired breaking changes.
crisbeto
force-pushed
the
breaking-changes-rework
branch
from
a111fa5 to
4bed263
Compare
jelbourn
pushed a commit
that referenced
this pull request
Sep 11, 2018
* Reworks the breaking change tslint rule to remove the logic that checks that there are no expired breaking changes. * Adds a new script that can be used to get an overview of the pending and expired breaking changes.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.