Skip to content

fix(portal): remove dependency on deprecated parentInjector #12986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2018
Merged

fix(portal): remove dependency on deprecated parentInjector #12986

merged 1 commit into from
Sep 11, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 5, 2018

The ViewContainerRef.parentInjector property is deprecated. These changes remove our dependency on it.

@crisbeto
fix(portal): remove dependency on deprecated parentInjector
3f83c25 
The `ViewContainerRef.parentInjector` property is deprecated. These changes remove our dependency on it.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Sep 5, 2018
@crisbeto crisbeto requested a review from jelbourn as a code owner September 5, 2018 16:21
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 5, 2018
@crisbeto
Copy link
Member Author

crisbeto commented Sep 5, 2018

@jelbourn I wasn't too sure whether to mark this for major or patch since there's a very small chance that it would introduce a behavior change.

@jelbourn jelbourn added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Sep 5, 2018
jelbourn
jelbourn approved these changes Sep 5, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn
Copy link
Member

jelbourn commented Sep 5, 2018

We can make it major since we have that coming up anyway

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 5, 2018
@jelbourn jelbourn merged commit f39e091 into angular:master Sep 11, 2018
@shanytc
Copy link

shanytc commented Dec 21, 2018

what do you use instead of parentInjector?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @shanytc @googlebot