fix(chips): arrow keys resetting focus to first chip #12987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
@crisbeto passes presubmit, just needs rebase |
|
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
Currently the chip list is set up to reset the focused when it's blurred. Since blurring also happens when focus is moved from one chip to another, the user isn't able to move more than one chip before they get reset.
crisbeto
force-pushed
the
chips-arrow-index-reset
branch
from
64b70ae to
2afcb8a
Compare
This was referenced Oct 10, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the chip list is set up to reset the focused chip when it's blurred. Since blurring also happens when focus is moved from one chip to another, the user isn't able to move more than one chip before they get reset.