fix(snack-bar): dismiss snack bar on destroy #13042
Conversation
Dismisses the currently-opened snack bar in `ngOnDestroy`.
googlebot
added
the
cla: yes
| @@ -45,7 +46,7 @@ export function MAT_SNACK_BAR_DEFAULT_OPTIONS_FACTORY(): MatSnackBarConfig { | |||
| * Service to dispatch Material Design snack bar messages. | |||
| */ | |||
| @Injectable({providedIn: MatSnackBarModule}) | |||
| export class MatSnackBar { | |||
| export class MatSnackBar implements OnDestroy { | |||
There was a problem hiding this comment.
Since @Injectables are just regular classes that are used as singletons, I don't believe there are any lifecycle hooks.
A quick test of checking for usage of OnInit shows that it is never called.
There was a problem hiding this comment.
AFAIK they only have OnDestroy. I believe it gets called when the associated module is unloaded. We've been doing it for the other services as well.
There was a problem hiding this comment.
Ahh, interesting. Didn't know about that. Then this makes sense to do 👍
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Dismisses the currently-opened snack bar in
ngOnDestroy.