feat(schematics): compatibility with Angular CLI 6.2.0 #13078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgrades the devkit dependencies to the latest versions. * Adds support for the newly introduced and published `project.targets` instead of `project.architect` (see: angular/angular-cli@3071608) * Compatibility behavior for a published but non-announced breaking change within the schematic context (see: https://github.com/angular/angular-cli/commit/9720077a4b5ae628ddfaf5f1a26bac3b04bdf637#diff-e73df838d6700d187eff76a50c7e1c53R233`) * Supports the new `project.targets` schema within the update schematics (in order to properly determine `tsconfig` files) Fixes angular#11438
devversion
added
P2
googlebot
added
the
cla: yes
devversion
commented
Sep 11, 2018
| if (project.architect && | ||
| project.architect[targetName] && | ||
| project.architect[targetName].options && | ||
| project.architect[targetName].options.tsConfig) { |
There was a problem hiding this comment.
I know that we could extract this into a more generic function in order to reduce duplication, but I prefer being explicit here.
devversion
force-pushed
the
feat/schematics-compatibility-6.2.0
branch
2 times, most recently
from
34cf0ae to
ddd9927
Compare
* Due to the fact that the @angular-devkit/schematics now handles Bazel better, the template files will be resolved through NodeJS. This means that the template files need to be referenced in the @//:node_modules label.
devversion
force-pushed
the
feat/schematics-compatibility-6.2.0
branch
from
ddd9927 to
1b76f15
Compare
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
project.targetsinstead ofproject.architect(see: angular/angular-cli@3071608)project.targetsschema within the update schematics (in order to properly determinetsconfigfiles)Fixes #11438