fix(grid-list): incorrectly laying out tiles for nested list #13086
Conversation
googlebot
added
the
cla: yes
| @@ -40,10 +41,14 @@ const MAT_FIT_MODE = 'fit'; | |||
| host: { | |||
| 'class': 'mat-grid-list', | |||
| }, | |||
| providers: [{ | |||
| provide: MAT_GRID_LIST, | |||
| useExisting: MatGridList | |||
There was a problem hiding this comment.
I don't quite follow why this is necessary- wouldn't injecting MatGridList do the same thing?
There was a problem hiding this comment.
It's there to avoid a circular import between the grid list and tile. The grid list has an import of the tile already.
crisbeto
force-pushed
the
13074/nested-grid-list
branch
from
9b8408a to
3e061e4
Compare
jelbourn
added
pr: lgtm
action: merge
|
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
3 similar comments
|
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
|
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
|
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
Fixes the grid list picking up the tiles of other nested grid lists, causing them to not being laid out correctly. Fixes angular#13074.
crisbeto
force-pushed
the
13074/nested-grid-list
branch
from
3e061e4 to
a1c0412
Compare
…#13086) Fixes the grid list picking up the tiles of other nested grid lists, causing them to not being laid out correctly. Fixes angular#13074.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes the grid list picking up the tiles of other nested grid lists, causing them to not being laid out correctly.
Fixes #13074.