chore(select): use computed pseudocheckbox size for multi select during 2018 material spec update transition #13110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
reviewed
Sep 13, 2018
src/lib/select/select.ts
Outdated
| // TODO(josephperrott): Remove after 2018 spec updates are fully merged. | ||
| /** Sets the psuedo checkbox padding size based on the width of the psuedo checkbox. */ | ||
| private _setPsuedoCheckboxPaddingSize() { | ||
| if (!SELECT_MULTIPLE_PANEL_PADDING_X) { |
There was a problem hiding this comment.
It would be pretty easy to also gate this on MatSelect.multiple so we don't have to hit the DOM at all.
crisbeto
reviewed
Sep 13, 2018
src/lib/select/select.ts
Outdated
| @@ -775,6 +778,17 @@ export class MatSelect extends _MatSelectMixinBase implements AfterContentInit, | |||
| return this._parentFormField ? `mat-${this._parentFormField.color}` : ''; | |||
| } | |||
|
|
|||
| // TODO(josephperrott): Remove after 2018 spec updates are fully merged. | |||
| /** Sets the psuedo checkbox padding size based on the width of the psuedo checkbox. */ | |||
…ng 2018 material spec update transition
josephperrott
force-pushed
the
checkbox-ripple
branch
from
b46e426 to
e4b809a
Compare
josephperrott
added
P2
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.