Skip to content

fix(progress-bar): buffer background animation stuttering #13114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2018
Merged

fix(progress-bar): buffer background animation stuttering #13114

merged 1 commit into from
Sep 14, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 13, 2018 •
edited
Loading

Fixes the animation for the buffer progress bar stuttering, because it didn't align to the dot size.

For reference:
demo

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Sep 13, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 13, 2018
@crisbeto crisbeto added target: major This PR is targeted for the next major release and removed cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release labels Sep 13, 2018
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 13, 2018
@crisbeto
Copy link
Member Author

Setting to major since it only applies for the new progress bar appearance.

@crisbeto
fix(progress-bar): buffer background animation stuttering
07a0171 
Fixes the animation for the buffer progress bar stuttering, because it didn't align the the dot size.
@crisbeto crisbeto force-pushed the progress-bar-animation-stutter branch from 0de2334 to 07a0171 Compare September 13, 2018 20:09
jelbourn
jelbourn approved these changes Sep 13, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 13, 2018
@jelbourn jelbourn merged commit 2f2e116 into angular:master Sep 14, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees

@josephperrott josephperrott

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @googlebot @jelbourn @josephperrott