Skip to content

refactor(table): allow readonly array in data source input #13137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2018
Merged

refactor(table): allow readonly array in data source input #13137

merged 1 commit into from
Oct 2, 2018

Conversation

crisbeto
Copy link
Member

Adds ReadonlyArray and Observable<ReadonlyArray> to the list of accepted types for the CdkTable.dataSource input.

Fixes #13126.

@crisbeto
refactor(table): allow readonly array in data source input
6701e3b 
Adds `ReadonlyArray` and `Observable<ReadonlyArray>` to the list of accepted types for the `CdkTable.dataSource` input.

Fixes angular#13126.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Sep 15, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 15, 2018
jelbourn
jelbourn approved these changes Sep 16, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 16, 2018
@vivian-hu-zz vivian-hu-zz merged commit ff23527 into angular:master Oct 2, 2018
roboshoes pushed a commit to roboshoes/material2 that referenced this pull request Oct 23, 2018
@crisbeto @roboshoes
refactor(table): allow readonly array in data source input (angular#1…
f5547d1 
…3137)

Adds `ReadonlyArray` and `Observable<ReadonlyArray>` to the list of accepted types for the `CdkTable.dataSource` input.

Fixes angular#13126.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(table): Use ReadonlyArray in 'datasource' property type
5 participants
@crisbeto @jelbourn @googlebot @andrewseguin @vivian-hu-zz