refactor(schematics): gracefully handle non statically analyzable values #13143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
pr: merge safe
target: major
googlebot
added
the
cla: yes
* Currently we just treat every value of `@Component#template` or `@Component#styles` as `ts.StringLiteral`. This works in the most cases, but there can be also developers that inline their template using some specific Webpack loaders or variables.
devversion
force-pushed
the
refactor/schematics-gracefully-non-statically-analyzable-values
branch
from
c79f576 to
3286914
Compare
jelbourn
approved these changes
Sep 16, 2018
| @@ -44,7 +44,7 @@ export class Walker extends ComponentWalker { | |||
| this._reportExtraStylesheetFiles(); | |||
| } | |||
|
|
|||
| visitInlineStylesheet(literal: ts.StringLiteral) { | |||
| visitInlineStylesheet(literal: ts.StringLiteralLike) { | |||
There was a problem hiding this comment.
How did you know about this type? I tried to find something for it, but the TS compiler looks mostly undocumented.
There was a problem hiding this comment.
I most of the time just look at the source or at the typescript.d.ts file. The d.ts files are pretty good to quickly explore the public API.
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we just treat every value of
@Component#templateor@Component#stylesasts.StringLiteral. This works in the most cases, but there can be also developers that inline their template using some specific Webpack loaders or variables.Also adds a rule failure instead of logging an error message if a resource couldn't be found. This makes it easier for people to figure out which files couldn't be determined (and to which component/directive the file belongs)