Skip to content

feat(bottom-sheet): add injection token for default options #13172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2018
Merged

feat(bottom-sheet): add injection token for default options #13172

merged 1 commit into from
Oct 2, 2018

Conversation

crisbeto
Copy link
Member

Introduces the MAT_BOTTOM_SHEET_DEFAULT_OPTIONS token which can be used to set the default options for MatBottomSheet.

Fixes #13149.

@crisbeto
feat(bottom-sheet): add injection token for default options
763012e 
Introduces the `MAT_BOTTOM_SHEET_DEFAULT_OPTIONS` token which can be used to set the default options for `MatBottomSheet`.

Fixes angular#13149.
@crisbeto crisbeto added the target: minor This PR is targeted for the next minor release label Sep 17, 2018
@crisbeto crisbeto requested a review from jelbourn as a code owner September 17, 2018 19:24
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 17, 2018
jelbourn
jelbourn approved these changes Sep 18, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 18, 2018
@vivian-hu-zz vivian-hu-zz merged commit 3de3851 into angular:master Oct 2, 2018
roboshoes pushed a commit to roboshoes/material2 that referenced this pull request Oct 23, 2018
@crisbeto @roboshoes
feat(bottom-sheet): add injection token for default options (angular#…
3cf96c2 
…13172)

Introduces the `MAT_BOTTOM_SHEET_DEFAULT_OPTIONS` token which can be used to set the default options for `MatBottomSheet`.

Fixes angular#13149.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create MAT_BOTTOM_SHEET_DEFAULT_OPTIONS InjectionToken
4 participants
@crisbeto @jelbourn @googlebot @vivian-hu-zz