fix(autocomplete): closing parent overlay when pressing escape #13413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we only listen for keydown events on the autocomplete trigger, however because the escape handler doesn't go through the `OverlayKeyboardDispatcher`, it means parent overlay will still receive the event, causing unintended side effects like the parent dialog closing when escape is pressed on an autocomplete. These changes switch the closing actions to go through the `OverlayRef.keydownEvents()`.
googlebot
added
the
cla: yes
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Oct 5, 2018
Along the same lines as angular#13413. Since `MatMenu` doesn't consume the `OverlayRef.keydownEvents`, it means that they'll be passed along to the next overlay in the stack.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Oct 5, 2018
Along the same lines as angular#13413. Since `MatMenu` doesn't consume the `OverlayRef.keydownEvents`, it means that they'll be passed along to the next overlay in the stack.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Oct 5, 2018
Along the same lines as angular#13413. Since `MatMenu` doesn't consume the `OverlayRef.keydownEvents`, it means that they'll be passed along to the next overlay in the stack.
roboshoes
pushed a commit
to roboshoes/material2
that referenced
this pull request
Oct 23, 2018
…r#13413) Currently we only listen for keydown events on the autocomplete trigger, however because the escape handler doesn't go through the `OverlayKeyboardDispatcher`, it means parent overlay will still receive the event, causing unintended side effects like the parent dialog closing when escape is pressed on an autocomplete. These changes switch the closing actions to go through the `OverlayRef.keydownEvents()`.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only listen for keydown events on the autocomplete trigger, however because the escape handler doesn't go through the
OverlayKeyboardDispatcher, it means parent overlay will still receive the event, causing unintended side effects like the parent dialog closing when escape is pressed on an autocomplete. These changes switch the closing actions to go through theOverlayRef.keydownEvents().