Skip to content

fix(experimental/dialog): clean up open dialogs on destroy #13421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 4, 2018

Cleans up all of the open dialogs when a dialog from cdk-experimental/dialog is destroyed.

Cleans up all of the open dialogs when a dialog from `cdk-experimental/dialog` is destroyed.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Oct 4, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 4, 2018
@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 4, 2018
@vivian-hu-zz vivian-hu-zz merged commit 84d8f5b into angular:master Oct 4, 2018
roboshoes pushed a commit to roboshoes/material2 that referenced this pull request Oct 23, 2018
…3421)

Cleans up all of the open dialogs when a dialog from `cdk-experimental/dialog` is destroyed.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants