fix(slide-toggle): using incorrect colors when disabled #13444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
googlebot
added
the
cla: yes
devversion
approved these changes
Oct 5, 2018
| @@ -40,6 +40,8 @@ $mat-slide-toggle-bar-track-width: $mat-slide-toggle-bar-width - $mat-slide-togg | |||
| } | |||
|
|
|||
| &.mat-disabled { | |||
| opacity: 0.38; | |||
There was a problem hiding this comment.
Add a comment that explains how you determined the opacity?
crisbeto
force-pushed
the
disabled-slide-toggle-color
branch
from
2d1f19c to
166a7ae
Compare
crisbeto
added
target: patch
Based on the latest Material Design spec, disable slide toggles are supposed to retain their color, but become slightly opaque.
crisbeto
force-pushed
the
disabled-slide-toggle-color
branch
from
166a7ae to
a082ad6
Compare
josephperrott
pushed a commit
that referenced
this pull request
Nov 19, 2018
Based on the latest Material Design spec, disable slide toggles are supposed to retain their color, but become slightly opaque.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the latest Material Design spec, disabled slide toggles are supposed to retain their color, but become slightly opaque.
For reference:
