Skip to content

perf(focus-monitor): mark event listeners as passive #13532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 19, 2018
Merged

perf(focus-monitor): mark event listeners as passive #13532

merged 2 commits into from
Oct 19, 2018

Conversation

devversion
Copy link
Member

@devversion devversion commented Oct 10, 2018 •
edited
Loading

  • If a browser supports passive events, we should also mark the FocusMonitor global event listeners as passive, because browsers could technically make optimizations by knowing that these event listeners won't prevented and therefore can run non-blocking.

@devversion
perf(focus-monitor): mark event listeners as passive
06b75fa 
* If a browser supports passive events, we should also mark the `FocusMonitor` event listeners as passive, because browsers could technically make optimizations by knowing that _these_ event listeners won't prevented and therefore can run non-blocking.
@devversion devversion added perf This issue is related to performance target: patch This PR is targeted for the next patch release labels Oct 10, 2018
@devversion devversion requested a review from jelbourn as a code owner October 10, 2018 09:57
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 10, 2018
crisbeto
crisbeto approved these changes Oct 10, 2018
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Oct 10, 2018
jelbourn
jelbourn approved these changes Oct 10, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott merged commit bfc00a0 into angular:master Oct 19, 2018
josephperrott pushed a commit that referenced this pull request Oct 19, 2018
@devversion @josephperrott
perf(focus-monitor): mark event listeners as passive (#13532)
b14d2d9
josephperrott pushed a commit that referenced this pull request Oct 19, 2018
@devversion @josephperrott
perf(focus-monitor): mark event listeners as passive (#13532)
ba0c820
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn jelbourn approved these changes

Assignees

@crisbeto crisbeto

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement perf This issue is related to performance target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@devversion @jelbourn @crisbeto @googlebot @josephperrott @mmalerba