build: set up tooling to ensure consistent prefixes for CSS classes #13563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables the `selector-class-pattern` Stylelint rule and fixes everything that wasn't consistent. Fixes angular#13545.
crisbeto
added
pr: merge safe
target: major
crisbeto
requested review from
andrewseguin,
devversion,
jelbourn and
josephperrott
as code owners
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
roboshoes
pushed a commit
to roboshoes/material2
that referenced
this pull request
Oct 23, 2018
…ngular#13563) Enables the `selector-class-pattern` Stylelint rule and fixes everything that wasn't consistent. Fixes angular#13545.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the
selector-class-patternStylelint rule and fixes everything that wasn't consistent.Fixes #13545.
Note: this rule applies to all files at the same time. If we want something that enforces that everything under
cdkis prefixed withcdk-, we'll have to do our own rule. I'm marking this as merge-safe since all the changes were either in one of the dev apps or in the doc examples.