Skip to content

build: move bazel config to workspace root #13644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

  • In order to prepare for the next bazel releases, we need to move the tools/bazel.rc to %workspace_root%/.bazelrc. The new location is already supported by 0.17.1+, but tools/.bazel.rc has been just left for backwards compatibility.
  • Also updates the bazel config to be more in sync with the bazelrc from angular/angular.

* In order to prepare for the next bazel releases, we need to move the `tools/bazel.rc` to `%workspace_root%/.bazelrc`. The new location is already supported by 0.17.1+, but `tools/.bazel.rc` has been just left for backwards compatibility.
* Also updates the bazel config to be more in sync with the bazelrc from `angular/angular`.
@devversion devversion added pr: merge safe target: major This PR is targeted for the next major release labels Oct 17, 2018
@devversion devversion requested a review from jelbourn as a code owner October 17, 2018 12:38
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 17, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 17, 2018
@josephperrott josephperrott merged commit 183df8f into angular:master Oct 17, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants