Skip to content

refactor(schematics): group ng-generate schematics in folder #13794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

devversion
Copy link
Member

  • Similarly to the CDK schematics, schematics that can be (ng-)generated should be grouped into its own directory. This cleans up the schematics folder and makes it clear where each schematic lives.
  • Removes a tslint ignore comment in a schematic test.

image

* Similarly to the CDK schematics, schematics that can be (ng-)`generated` should be grouped into its own directory. This cleans up the schematics folder and makes it clear where each schematic lives.
* Removes a tslint ignore comment in a schematic test.
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Oct 24, 2018
@devversion devversion requested a review from jelbourn as a code owner October 24, 2018 16:16
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 24, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 24, 2018
@mmalerba mmalerba merged commit f5d42cd into angular:master Oct 24, 2018
mmalerba pushed a commit that referenced this pull request Oct 26, 2018
* Similarly to the CDK schematics, schematics that can be (ng-)`generated` should be grouped into its own directory. This cleans up the schematics folder and makes it clear where each schematic lives.
* Removes a tslint ignore comment in a schematic test.
atscott pushed a commit to atscott/components that referenced this pull request Nov 5, 2018
…#13794)

* Similarly to the CDK schematics, schematics that can be (ng-)`generated` should be grouped into its own directory. This cleans up the schematics folder and makes it clear where each schematic lives.
* Removes a tslint ignore comment in a schematic test.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants