Skip to content

fix(list): remove disabled selection list hover feedback on mobile #13850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2018

Conversation

crisbeto
Copy link
Member

Currently on mobile devices we counteract the :hover styling by removing the background, however this ends up removing the disabled styling.

For reference:
angular_material_-_google_chrome_2018-10-28_20-15-12

Currently on mobile devices we counteract the `:hover` styling by removing the background, however this ends up removing the disabled styling.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Oct 28, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 28, 2018
@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 28, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 0589881 into angular:master Oct 29, 2018
atscott pushed a commit to atscott/components that referenced this pull request Nov 5, 2018
…ngular#13850)

Currently on mobile devices we counteract the `:hover` styling by removing the background, however this ends up removing the disabled styling.
jelbourn pushed a commit that referenced this pull request Nov 6, 2018
…13850)

Currently on mobile devices we counteract the `:hover` styling by removing the background, however this ends up removing the disabled styling.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants