Skip to content

build(drag-drop): clean up bazel config #13934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 1, 2018

Removes the sass_binary since we don't ship CSS with cdk/drag-drop anymore and removes cdk/overlay from the dependencies.

@crisbeto crisbeto added pr: merge safe target: patch This PR is targeted for the next patch release labels Nov 1, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 1, 2018
Removes the `sass_binary` since we don't ship CSS with `cdk/drag-drop` anymore and removes `cdk/overlay` from the dependencies.
@crisbeto crisbeto force-pushed the drag-drop-bazel-cleanup branch from 94017c6 to b87f87a Compare November 1, 2018 21:47
@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 1, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit a619ddc into angular:master Nov 1, 2018
atscott pushed a commit to atscott/components that referenced this pull request Nov 5, 2018
Removes the `sass_binary` since we don't ship CSS with `cdk/drag-drop` anymore and removes `cdk/overlay` from the dependencies.
jelbourn pushed a commit that referenced this pull request Nov 6, 2018
Removes the `sass_binary` since we don't ship CSS with `cdk/drag-drop` anymore and removes `cdk/overlay` from the dependencies.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants