refactor(a11y): reuse global event listeners in focus monitor #14205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently whenever we bind global events in the `FocusMonitor`, we re-create the global event listeners and we re-declare the function to unregister them. This isn't necessary, because the functions won't change. These change rework the listeners so they're declared once and reused.
googlebot
added
the
cla: yes
mmalerba
approved these changes
Nov 20, 2018
mmalerba
added
pr: lgtm
action: merge
jelbourn
pushed a commit
that referenced
this pull request
Dec 3, 2018
Currently whenever we bind global events in the `FocusMonitor`, we re-create the global event listeners and we re-declare the function to unregister them. This isn't necessary, because the functions won't change. These change rework the listeners so they're declared once and reused.
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
…r#14205) Currently whenever we bind global events in the `FocusMonitor`, we re-create the global event listeners and we re-declare the function to unregister them. This isn't necessary, because the functions won't change. These change rework the listeners so they're declared once and reused.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently whenever we bind global events in the
FocusMonitor, we re-create the global event listeners and we re-declare the function to unregister them. This isn't necessary, because the functions won't change. These change rework the listeners so they're declared once and reused.