build: setup cronjob to run tests against angular snapshots #14217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
devversion
force-pushed
the
build/cronjob-angular-snapshots
branch
from
9bf6575 to
bd12638
Compare
* Sets up a cronjob workflow that runs the local browser tests against the Angular Github snapshot builds at midnight everyday. * No longer saves cache multiple times. This can cause unexpected behavior. * Sorts jobs in `config.yml` to group all `tests_XX` jobs. Closes angular#12516.
devversion
force-pushed
the
build/cronjob-angular-snapshots
branch
from
bd12638 to
6940ea5
Compare
| @@ -269,8 +265,6 @@ jobs: | |||
|
|
|||
| - run: ./scripts/circleci/publish-snapshots.sh | |||
|
|
|||
| - *save_cache | |||
There was a problem hiding this comment.
We no longer want to save the cache here?
There was a problem hiding this comment.
Yeah, the cache should be only updated once in the build_release_packages task. It doesn't make sense to store multiple times because the checksum shouldn't differ.
jelbourn
added
pr: lgtm
action: merge
jelbourn
pushed a commit
that referenced
this pull request
Dec 3, 2018
* Sets up a cronjob workflow that runs the local browser tests against the Angular Github snapshot builds at midnight everyday. * No longer saves cache multiple times. This can cause unexpected behavior. * Sorts jobs in `config.yml` to group all `tests_XX` jobs. Closes #12516.
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
…14217) * Sets up a cronjob workflow that runs the local browser tests against the Angular Github snapshot builds at midnight everyday. * No longer saves cache multiple times. This can cause unexpected behavior. * Sorts jobs in `config.yml` to group all `tests_XX` jobs. Closes angular#12516.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config.ymlto group alltests_XXjobs.Closes #12516.