Skip to content

build: allow jumping to base class of api class #14232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2018

Conversation

devversion
Copy link
Member

References #14122

@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Nov 21, 2018
@devversion devversion requested a review from jelbourn as a code owner November 21, 2018 21:28
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 21, 2018
@devversion devversion force-pushed the build/docs-dgeni-extends-link branch from 63acc39 to 1476564 Compare November 21, 2018 21:31
devversion added a commit to angular/material.angular.io that referenced this pull request Nov 22, 2018
Combined with: angular/components#14232, this
fixes that the extends clause anchor will be shifted by the
`header-link` styling.

Also improves the general visuals of the extends clause, since those are
now clickable. Additionally updates the lock file to reflect the latest
package changes.
@devversion
Copy link
Member Author

Caretaker note. if you merge this PR, please consider merging angular/material.angular.io#558

@devversion devversion added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Nov 22, 2018
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 27, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 9ccda94 into angular:master Nov 27, 2018
jelbourn pushed a commit to angular/material.angular.io that referenced this pull request Nov 30, 2018
Combined with: angular/components#14232, this
fixes that the extends clause anchor will be shifted by the
`header-link` styling.

Also improves the general visuals of the extends clause, since those are
now clickable. Additionally updates the lock file to reflect the latest
package changes.
jelbourn pushed a commit that referenced this pull request Dec 3, 2018
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants