Skip to content

fix(form-field): long labels and option values going under select arrow #14268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2018
Merged

fix(form-field): long labels and option values going under select arrow #14268

merged 1 commit into from
Dec 3, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 25, 2018 •
edited
Loading

Fixes very long form field labels and option value colliding with the arrow that is rendered next to a select inside a mat-form-field.

For reference:
angular_material_-_google_chrome_2018-11-25_22-17-04
angular_material_-_google_chrome_2018-11-25_22-19-12

@crisbeto
fix(form-field): long labels and option values going under select arrow
6172501 
Fixes very long form field labels and option value colliding with the arrow that is rendered next to a `select` inside a `mat-form-field`.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Nov 25, 2018
@crisbeto crisbeto requested a review from mmalerba as a code owner November 25, 2018 21:33
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 25, 2018
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 3, 2018
@mmalerba mmalerba merged commit 166279b into angular:master Dec 3, 2018
mmalerba pushed a commit that referenced this pull request Dec 10, 2018
@crisbeto @mmalerba
fix(form-field): long labels and option values going under select arr…
22dbd0f 
…ow (#14268)

Fixes very long form field labels and option value colliding with the arrow that is rendered next to a `select` inside a `mat-form-field`.
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@crisbeto @josephperrott
fix(form-field): long labels and option values going under select arr…
ab43a65 
…ow (angular#14268)

Fixes very long form field labels and option value colliding with the arrow that is rendered next to a `select` inside a `mat-form-field`.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @googlebot @mmalerba @vivian-hu-zz