Skip to content

fix(datepicker): update validation when switching from null to error input #14423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2019

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Dec 7, 2018

fixes #12633, #11931

@mmalerba mmalerba added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful G This is is related to a Google internal issue labels Dec 7, 2018
@mmalerba mmalerba requested a review from crisbeto December 7, 2018 20:09
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 7, 2018
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we capture this in a unit test?

@mmalerba
Copy link
Contributor Author

Done

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Dec 10, 2018
@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Dec 20, 2018
@AmorrowPlus
Copy link

Any idea on when this will make it in?

@andrewseguin andrewseguin merged commit 5aefe60 into angular:master Jan 25, 2019
andrewseguin pushed a commit that referenced this pull request Jan 25, 2019
…input (#14423)

* fix(datepicker): update validation when switching from null to error
input

* add test
@sudd03
Copy link

sudd03 commented Jul 5, 2019

This change introduced a new issue for date picker. The form-control updateOn blur event is not working properly.

For datepicker form control which has updateOn set to blur but after removing the date from right or left it emitting value change event.

It should emit value change event only for blur.

Here is example with @angular/material 7.3.1 version in which have issue.

https://datepicker-issue-with-angularmaterial-731.stackblitz.io

Earlier version (@angular/material 7.2.2), the blur event was properly working.

https://datepicker-issue-with-angularmaterial-722.stackblitz.io

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datepicker and Reactive Forms validation bug
6 participants