-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(datepicker): update validation when switching from null to error input #14423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can we capture this in a unit test?
Done |
7a01d46
to
a9b50d8
Compare
Any idea on when this will make it in? |
…input (#14423) * fix(datepicker): update validation when switching from null to error input * add test
This change introduced a new issue for date picker. The form-control updateOn blur event is not working properly. For datepicker form control which has updateOn set to blur but after removing the date from right or left it emitting value change event. It should emit value change event only for blur. Here is example with @angular/material 7.3.1 version in which have issue. https://datepicker-issue-with-angularmaterial-731.stackblitz.io Earlier version (@angular/material 7.2.2), the blur event was properly working. https://datepicker-issue-with-angularmaterial-722.stackblitz.io |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
fixes #12633, #11931