Skip to content

fix(chips): don't handle separator keys while pressing modifiers #14424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2018
Merged

fix(chips): don't handle separator keys while pressing modifiers #14424

merged 1 commit into from
Dec 12, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 7, 2018

No longer reacts to pressing the separator keys, if a modifier key is being held down. This avoids interfering with other OS-level shortcuts.

@crisbeto
fix(chips): don't handle separator keys while pressing modifiers
6b7e651 
No longer reacts to pressing the separator keys, if a modifier key is being held down. This avoids interfering with other OS-level shortcuts.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Dec 7, 2018
@crisbeto crisbeto requested a review from jelbourn as a code owner December 7, 2018 20:43
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 7, 2018
jelbourn
jelbourn approved these changes Dec 11, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 11, 2018
@vivian-hu-zz vivian-hu-zz merged commit d1cec1f into angular:master Dec 12, 2018
@forssri
Copy link
Contributor

forssri commented Dec 13, 2018

Thanks for this 👍

josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@crisbeto @josephperrott
fix(chips): don't handle separator keys while pressing modifiers (ang…
2687bed 
…ular#14424)

No longer reacts to pressing the separator keys, if a modifier key is being held down. This avoids interfering with other OS-level shortcuts.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @forssri @jelbourn @googlebot @vivian-hu-zz