build: generate api docs for cdk using bazel #14427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
pr: merge safe
target: patch
devversion
requested review from
andrewseguin,
crisbeto,
jelbourn,
josephperrott and
mmalerba
as code owners
googlebot
added
the
cla: yes
devversion
force-pushed
the
build/package-component-api-docs-content
branch
from
0d2fe67 to
078bb35
Compare
devversion
force-pushed
the
build/package-component-api-docs-content
branch
2 times, most recently
from
ba1259d to
48763d9
Compare
devversion
force-pushed
the
build/package-component-api-docs-content
branch
from
48763d9 to
3a31ea9
Compare
|
This one is ready for review now. The dgeni part turned out pretty well, just having to export the source files for each package is a bit odd IMO, but we cannot just glob from parent directories because those are own Bazel packages. |
jelbourn
added
pr: lgtm
action: merge
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
highlightjsI've held off with Material for now because this PR is already big enough. Note that we can remove a lot of Gulp code once we fully use Bazel for the docs generation.