Skip to content

build: run api golden checks in separate ci job #14452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2018
Merged

build: run api golden checks in separate ci job #14452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,25 @@ jobs:
- *copy_bazel_config

- run: bazel build src/...
- run: bazel test src/... tools/public_api_guard/...
- run: bazel test src/...

# Note: We want to save the cache in this job because the workspace cache also
# includes the Bazel repository cache that will be updated in this job.
- *save_cache

# --------------------------------------------------------------------------------------------
# Job that runs ts-api-guardian against our API goldens in "tools/public_api_guard".
# This job fails whenever an API has been updated but not explicitly approved through goldens.
# --------------------------------------------------------------------------------------------
api_golden_checks:
resource_class: xlarge
<<: *job_defaults
steps:
- *checkout_code
- *restore_cache

- run: bazel test tools/public_api_guard/...

# ----------------------------------------------------------------
# Job that runs the e2e tests with Protractor and Chrome Headless
# ----------------------------------------------------------------
Expand Down Expand Up @@ -297,6 +310,7 @@ workflows:
build_and_test:
jobs:
- bazel_build_test
- api_golden_checks

unit_tests:
jobs:
Expand Down