Skip to content

build: publish release script should add release notes to tag #14599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

  • Adds the release notes to the release tag. This can be also used in the future to create the Github release through the API.

Blocked on #14595

@devversion devversion added blocked This issue is blocked by some external factor, such as a prerequisite PR pr: merge safe target: patch This PR is targeted for the next patch release labels Dec 20, 2018
@devversion devversion requested a review from jelbourn as a code owner December 20, 2018 21:33
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 20, 2018
@devversion devversion force-pushed the build/extract-release-notes-from-changelog branch from 2de278a to 3d38b67 Compare December 20, 2018 21:40
@devversion devversion removed the blocked This issue is blocked by some external factor, such as a prerequisite PR label Dec 20, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 20, 2018
const releaseNotesRegex = new RegExp(`(##? ${escapedVersion}.*?)##? 7\\.`, 's');
const matches = releaseNotesRegex.exec(changelogContent);

return matches ? matches[1].trim() : null;
Copy link
Member Author

@devversion devversion Dec 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to think about a more efficient way and initially used a read stream since the changelog file can technically become huge over the years, but that was just so much overhead, so I just went with the simple approach.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move all the pre 5.0.0 stuff to another file at some point

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ngbot
Copy link

ngbot bot commented Dec 20, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "branch-manager" is failing
    pending status "ci/circleci: tests_local_browsers" is pending
    pending status "ci/circleci: tests_browserstack" is pending
    pending status "ci/circleci: tests_saucelabs" is pending
    pending status "ci/circleci: bazel_build_test" is pending
    pending status "ci/circleci: build_release_packages" is pending
    pending status "ci/circleci: e2e_tests" is pending
    pending status "ci/circleci: prerender_build" is pending
    pending status "ci/circleci: lint" is pending
    pending status "ci/circleci: api_golden_checks" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn jelbourn merged commit 27d3b02 into angular:master Dec 20, 2018
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants