Skip to content

build: prepare schematics for v8 #14667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

  • Prepares the schematics for V8
  • Dynamically resolves the test cases so that we don't need to hardcode them for each version

@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Dec 28, 2018
@devversion devversion requested a review from jelbourn as a code owner December 28, 2018 16:52
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 28, 2018
* Prepares the schematics for V8
* Dynamically resolves the test cases so that we don't need to hardcode them for each version
@devversion devversion force-pushed the build/prepare-schematics-v8 branch from b830ba3 to 6b29a9f Compare December 28, 2018 21:55
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 9, 2019
@andrewseguin andrewseguin merged commit bb419d3 into angular:master Jan 9, 2019
andrewseguin pushed a commit that referenced this pull request Jan 10, 2019
* Prepares the schematics for V8
* Dynamically resolves the test cases so that we don't need to hardcode them for each version
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
* Prepares the schematics for V8
* Dynamically resolves the test cases so that we don't need to hardcode them for each version
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants