Skip to content

build: run e2e tests with bazel rbe #14870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

@devversion devversion commented Jan 17, 2019

  • Similar to other Bazel jobs, we should enable remote execution for the e2e tests. These currently build Angular Material in order to serve the e2e-app, so this could slow-down CI. Ideally remote caching would be also accepted, but this will be discussed soon.

Pretty similar to #14867, but decided to make a new PR because the commit message would be off.

@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Jan 17, 2019
@devversion devversion requested a review from jelbourn as a code owner January 17, 2019 20:17
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 17, 2019
@devversion devversion force-pushed the build/run-e2e-tests-bazel-rbe branch from 02c0929 to 2c25895 Compare January 17, 2019 20:40
* Similar to other Bazel jobs, we should enable remote execution for the e2e tests. These currently build Angular Material in order to serve the e2e-app, so this could slow-down CI. Ideally remote caching would be also accepted, but this will be discussed soon.
@devversion devversion force-pushed the build/run-e2e-tests-bazel-rbe branch from 2c25895 to e879d02 Compare January 17, 2019 21:35
@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 17, 2019
@ngbot
Copy link

ngbot bot commented Jan 17, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "branch-manager" is failing
    pending status "ci/circleci: bazel_build_test" is pending
    pending status "ci/circleci: tests_local_browsers" is pending
    pending status "ci/circleci: tests_saucelabs" is pending
    pending status "ci/circleci: e2e_tests" is pending
    pending status "ci/circleci: tests_browserstack" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@vivian-hu-zz vivian-hu-zz merged commit 668b235 into angular:master Jan 17, 2019
s2-abdo pushed a commit to s2-abdo/material2 that referenced this pull request Jan 18, 2019
* Similar to other Bazel jobs, we should enable remote execution for the e2e tests. These currently build Angular Material in order to serve the e2e-app, so this could slow-down CI. Ideally remote caching would be also accepted, but this will be discussed soon.
vivian-hu-zz pushed a commit that referenced this pull request Jan 18, 2019
* Similar to other Bazel jobs, we should enable remote execution for the e2e tests. These currently build Angular Material in order to serve the e2e-app, so this could slow-down CI. Ideally remote caching would be also accepted, but this will be discussed soon.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants