fix(stepper): unable to tab to step content #14892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Along the same line as angular#14808. Fixes not being able to reach the content of a step if it doesn't have focusable content already. Based on the [tabs example from the accessibility guidelines](https://www.w3.org/TR/wai-aria-practices-1.1/examples/tabs/tabs-2/tabs.html).
googlebot
added
the
cla: yes
mmalerba
added
pr: lgtm
action: merge
mmalerba
approved these changes
Jan 19, 2019
josephperrott
added
the
target: patch
josephperrott
pushed a commit
that referenced
this pull request
Mar 5, 2019
Along the same line as #14808. Fixes not being able to reach the content of a step if it doesn't have focusable content already. Based on the [tabs example from the accessibility guidelines](https://www.w3.org/TR/wai-aria-practices-1.1/examples/tabs/tabs-2/tabs.html).
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Aug 18, 2019
A while ago in angular#14892 we added a `tabindex` to the content of the current step, however since then we consulted with the a11y team and it looks like adding the `tabindex` there isn't the best approach. Fixes angular#16692.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along the same line as #14808. Fixes not being able to reach the content of a step if it doesn't have focusable content already. Based on the tabs example from the accessibility guidelines.