fix(progress-bar): clear aria-valuenow in indeterminate or query mode #15019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
Accessibility
googlebot
added
the
cla: yes
jelbourn
approved these changes
Feb 20, 2019
| progressComponent.mode = 'indeterminate'; | ||
| fixture.detectChanges(); | ||
|
|
||
| expect(progressElement.nativeElement.hasAttribute('aria-valuenow')).toBe(false); |
There was a problem hiding this comment.
Add assertion messages like
.toBe(false, 'Expected aria-valuenow to be absent for mode="indeterminate"');
jelbourn
added
pr: lgtm
action: merge
Clears the `aria-valuenow` attribute when the progress bar is in indeterminate or query mode, [based on the a11y spec](https://www.w3.org/TR/wai-aria-1.1/#progressbar). Fixes angular#15016.
crisbeto
force-pushed
the
15016/progress-bar-aria-valuenow
branch
from
a058afc to
99f82e0
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clears the
aria-valuenowattribute when the progress bar is in indeterminate or query mode, based on the a11y spec.Fixes #15016.