Skip to content

fix(menu): prevent removal of mat-elevation class #15035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2019
Merged

fix(menu): prevent removal of mat-elevation class #15035

merged 1 commit into from
Feb 5, 2019

Conversation

swseverance
Copy link
Contributor

  • Fixes a bug to prevent mat-elevation classes from being removed
    from menu panel after MatMenu's panelClass input is updated

@swseverance swseverance requested a review from crisbeto as a code owner January 31, 2019 12:30
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 31, 2019
@swseverance
Copy link
Contributor Author

StackBlitz

crisbeto
crisbeto reviewed Feb 1, 2019
View reviewed changes
@swseverance
fix(menu): prevent removal of mat-elevation class
8064baa 
* Fixes a bug to prevent mat-elevation classes from being removed
  from menu panel after `MatMenu`'s `panelClass` input is updated
@swseverance
Copy link
Contributor Author

@crisbeto suggested changes made. Thanks

crisbeto
crisbeto approved these changes Feb 2, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Feb 2, 2019
jelbourn
jelbourn approved these changes Feb 5, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit e126876 into angular:master Feb 5, 2019
jelbourn pushed a commit that referenced this pull request Feb 11, 2019
@swseverance @jelbourn
fix(menu): prevent removal of mat-elevation class (#15035)
8069641 
Fixes a bug to prevent mat-elevation classes from being removed from menu panel after `MatMenu`'s `panelClass` input is updated
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swseverance @jelbourn @crisbeto @googlebot