fix(chips): unable to tab out of chip list with input on firefox #15060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
Accessibility
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
15011/chip-input-focus-escape-firefox
branch
from
2f8a8bb to
0b3c47f
Compare
|
I don't quite follow why the focus is trapped- what's going on there? |
|
If I remember correctly, the problem was on Firefox where if you tabbed from a chip, your focus would land on the chip list because it has a |
|
@crisbeto this passes presubmit, just needs a rebase |
Fixes user focus being wrapped back to the first chip, when trying to tab out of a chip list that has an input, on Firefox. Fixes angular#15011.
|
Rebased. |
crisbeto
force-pushed
the
15011/chip-input-focus-escape-firefox
branch
from
0b3c47f to
fcc45fc
Compare
RudolfFrederiksen
pushed a commit
to RudolfFrederiksen/material2
that referenced
this pull request
Jun 21, 2019
…ular#15060) Fixes user focus being wrapped back to the first chip, when trying to tab out of a chip list that has an input, on Firefox. Fixes angular#15011.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes user focus being wrapped back to the first chip, when trying to tab out of a chip list that has an input, on Firefox.
Note: the Browserstack failure seems to unrelated.
Fixes #15011.